Add a System.Text.Json based IJsonHelper #9566
Conversation
| public IHtmlContent Serialize(object value) | ||
| { | ||
| // JsonSerializer always encodes | ||
| var json = JsonSerializer.ToString(value, value.GetType(), _mvcOptions.SerializerOptions); |
There was a problem hiding this comment.
System.Text.Json's default and only behavior is the equivalent of StringEscapeHandling.EscapeNonAscii (https://www.newtonsoft.com/json/help/html/T_Newtonsoft_Json_StringEscapeHandling.htm). There isn't a way (as yet) to turn this behavior off.
There was a problem hiding this comment.
One thing to note is that the extension method to IJsonHelper that accepts a setting is currently only available when you use the Json.NET based helper: https://github.com/aspnet/AspNetCore/blob/master/src/Mvc/Mvc.NewtonsoftJson/src/JsonHelperExtensions.cs#L30-L33.
We could consider adding it in the future if somebody asks for it. As of now, the extension primarily exists to maintain parity with 2.x
| { | ||
| protected override IJsonHelper GetJsonHelper() | ||
| { | ||
| var mvcOptions = new MvcOptions { SerializerOptions = { PropertyNamingPolicy = JsonNamingPolicy.CamelCase } }; |
There was a problem hiding this comment.
This should get cleanup shortly.
Eilon
added
the
area-mvc
| public IHtmlContent Serialize(object value) | ||
| { | ||
| // JsonSerializer always encodes | ||
| var json = JsonSerializer.ToString(value, value.GetType(), _mvcOptions.SerializerOptions); |
There was a problem hiding this comment.
This will null reference exception when value is null.
Add a test with fix.
There was a problem hiding this comment.
Nice catch! Fixed and added test
pranavkm
force-pushed
the
prkrishn/jsonresultexecutor
branch
from
955404c to
9176508
Compare
pranavkm
force-pushed
the
prkrishn/systemtextjsonhelper
branch
from
8f39208 to
c138325
Compare
| public IHtmlContent Serialize(object value) | ||
| { | ||
| // JsonSerializer always encodes | ||
| var json = JsonSerializer.ToString(value, value?.GetType() ?? typeof(object), _mvcOptions.SerializerOptions); |
There was a problem hiding this comment.
Hmmm, is there no overload on JsonSerializer that just takes a value?
There was a problem hiding this comment.
I was under the impression that https://github.com/dotnet/corefx/issues/36166 wasn't done. But it works for object value. Updated
Fixes #9564