Skip to content

Update the guide to target .NET 5 #22297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 12, 2021
Merged

Conversation

vitek-karas
Copy link
Member

3.0 is out of support.

The respective sample is updated to .NET 5 in dotnet/samples#4096.

3.0 is out of support.
@vitek-karas vitek-karas requested a review from tdykstra as a code owner January 11, 2021 09:34
@vitek-karas vitek-karas self-assigned this Jan 11, 2021
@vitek-karas
Copy link
Member Author

@elinor-fung what's the maintenance mechanism for the snippets for this guide: https://github.com/dotnet/docs/tree/master/samples/snippets/core/tutorials/creating-app-with-plugin-support/csharp. That seems to be a full copy of the sample project. Is there a way to refer to the samples repo directly instead? Should I update the snippets with the latest from samples manually?

@tdykstra
Copy link
Contributor

Should I update the snippets with the latest from samples manually?

Yes -- We used to do cross-repo references for code, but it causes problems whenever you update the doc or code, so we deliberately moved away from that. The duplication is unfortunate but is better than the alternative.

@vitek-karas vitek-karas requested a review from a team as a code owner January 11, 2021 19:08
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants