-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Update Path.GetTempPath description #10118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tagging subscribers to this area: @dotnet/area-system-io |
Learn Build status updates of commit 48ec09b: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Co-authored-by: Genevieve Warren <[email protected]>
Learn Build status updates of commit 97f2c48: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit 7fd711d: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Co-authored-by: Theodore Tsirpanis <[email protected]>
Learn Build status updates of commit 4748704: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
@adamsitnik Just to be pedantic, there are some cases where
AFAIK we don't perform an OS version check. We simply look for the existence of the export. This is another case where we should link to the authoritative documentation for the underlying Win32 function rather than trying to duplicate it ourselves (and risk getting out of sync if they make a change regarding available versions). |
That is true, but the change in .NET Framework (4.8.*) was not included in earlier builds of Windows, even if the GetTempPath2 API was available, as Windows ships .NET Framework itself. For example, my co-worker has a Windows 11, Build 22631.3737, and the behaviour of C# applications targeted at I agree linking the win32 API docs would be an improvement. |
Feedback from netfx servicing:
I'll send shortly a new iteration with includes these changes and merges Genevieve's recommendations. |
Learn Build status updates of commit 8d7b7ab: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Thank you @GrabYourPitchforks ! |
Co-authored-by: Genevieve Warren <[email protected]>
Learn Build status updates of commit 88a640d: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Recently we have backported dotnet/runtime#72452 to all supported versions of .NET and .NET Framework.
fixes dotnet/runtime#105012