-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Update C# examples for ja-JP and en-US DateTimeFormatInfo #10141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update C# examples for ja-JP and en-US DateTimeFormatInfo #10141
Conversation
Learn Build status updates of commit d7166c1: ✅ Validation status: passedFor more details, please refer to the build report. For any questions, please:
|
I see |
...harp/System.Globalization/DateTimeFormatInfo/FullDateTimePattern/dtfi_fulldatetimepattern.cs
Outdated
Show resolved
Hide resolved
@gewarren do you know why the CI is failing while updating only existing sample source? |
Yes, we are trying to get project files added for every snippet, so if a project file doesn't exist for any snippet that's touched, it errors. |
Should we ignore the error? or we must add the project file with the change? |
If Matous can add one, that would be great. Something like this, but might as well target .NET 8: https://github.com/dotnet/dotnet-api-docs/blob/main/snippets/csharp/System.Globalization/DateTimeFormatInfo/FullDateTimePattern/Project.csproj |
Learn Build status updates of commit 2ff3d3d: ✅ Validation status: passedFor more details, please refer to the build report. For any questions, please:
|
I added the Project.csproj, however now it complains that Should I rename the |
Yes, please. Sorry for the hassle. |
No problem, thank you for the help. Looks to be green now. |
Summary
In dotnet/runtime#105097, we discovered that the example provided for .NET DateTimePattern are out-of-date. In this PR, we update the examples of
FullDateTimePattern
,LongDatePattern
,MonthDayPattern
foren-US
andja-JP
cultures.cc: @tarekgh @vitek-karas