Skip to content

Port System & System.Numerics new docs #10152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jul 30, 2024

Conversation

carlossanlop
Copy link
Contributor

@carlossanlop carlossanlop commented Jul 25, 2024

@dotnet/area-system-runtime @dotnet/area-system-numerics @dotnet/area-system-numerics-tensors @gewarren @directhex PTAL

@carlossanlop carlossanlop requested review from a team as code owners July 25, 2024 19:03
@ghost ghost added the area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. label Jul 25, 2024

This comment was marked as outdated.

This comment was marked as outdated.

@carlossanlop carlossanlop added area-System.Numerics and removed area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. labels Jul 25, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-numerics

Copy link
Member

@tannergooding tannergooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest of the changes generally LGTM

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not finished yet - the UI has just become unbearably slow.

This comment was marked as outdated.

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final comments.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Copy link

Learn Build status updates of commit a0ea503:

⚠️ Validation status: warnings

File Status Preview URL Details
[xml/System.Numerics.Tensors/ReadOnlyTensorSpan1.xml](https://github.com/carlossanlop/dotnet-api-docs/blob/PortSystemNumerics/xml/System.Numerics.Tensors/ReadOnlyTensorSpan1.xml) ⚠️Warning View Details
xml/System.Numerics.Tensors/Tensor.xml ⚠️Warning View Details
[xml/System.Numerics.Tensors/TensorSpan1.xml](https://github.com/carlossanlop/dotnet-api-docs/blob/PortSystemNumerics/xml/System.Numerics.Tensors/TensorSpan1.xml) ⚠️Warning View Details
xml/System.Numerics/Vector.xml ⚠️Warning View Details
xml/System.Numerics.Tensors/ReadOnlyTensorSpan`1+Enumerator.xml ✅Succeeded View
xml/System.Numerics.Tensors/Tensor`1.xml ✅Succeeded View
xml/System.Numerics.Tensors/TensorPrimitives.xml ✅Succeeded View
xml/System.Numerics.Tensors/TensorSpan`1+Enumerator.xml ✅Succeeded View
xml/System.Numerics/BigInteger.xml ✅Succeeded View
xml/System.Numerics/Complex.xml ✅Succeeded View
xml/System.Numerics/IFloatingPoint`1.xml ✅Succeeded View
xml/System.Numerics/INumberBase`1.xml ✅Succeeded View
xml/System.Numerics/Vector`1.xml ✅Succeeded View
xml/System.Numerics/Vector2.xml ✅Succeeded View
xml/System.Numerics/Vector3.xml ✅Succeeded View
xml/System.Numerics/Vector4.xml ✅Succeeded View
xml/System/Array.xml ✅Succeeded View
xml/System/BitConverter.xml ✅Succeeded View
xml/System/Byte.xml ✅Succeeded View
xml/System/Char.xml ✅Succeeded View
xml/System/Console.xml ✅Succeeded View
xml/System/Convert.xml ✅Succeeded View
xml/System/DateOnly.xml ✅Succeeded View
xml/System/DateTime.xml ✅Succeeded View
xml/System/DateTimeOffset.xml ✅Succeeded View

This comment lists only the first 25 files in the pull request.

[xml/System.Numerics.Tensors/ReadOnlyTensorSpan1.xml](https://github.com/carlossanlop/dotnet-api-docs/blob/PortSystemNumerics/xml/System.Numerics.Tensors/ReadOnlyTensorSpan1.xml)

  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Numerics.Tensors.ReadOnlyTensorSpan<T>'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Numerics.Tensors.ReadOnlyTensorSpan<T>'.

xml/System.Numerics.Tensors/Tensor.xml

  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Single.DegreesToRadians'.

[xml/System.Numerics.Tensors/TensorSpan1.xml](https://github.com/carlossanlop/dotnet-api-docs/blob/PortSystemNumerics/xml/System.Numerics.Tensors/TensorSpan1.xml)

  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Numerics.Tensors.TensorSpan<T>'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Numerics.Tensors.TensorSpan<T>'.

xml/System.Numerics/Vector.xml

  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Numerics.Vector{System.Single}'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Numerics.Vector{System.UInt32}'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Numerics.Vector{System.Double}'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Numerics.Vector{System.Int64}'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Numerics.Vector{System.Double}'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Numerics.Vector{System.UInt64}'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@carlossanlop carlossanlop merged commit cfb5572 into dotnet:main Jul 30, 2024
3 checks passed
@carlossanlop carlossanlop deleted the PortSystemNumerics branch July 30, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants