CI Update - Remove System.Private.ServiceModel package #10164
Conversation
Build.Reason:Manual by Genevieve Warren Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=441514&view=results source_repo.branch:remove-systemprivateservicemodel source_repo.url:https://apidrop.visualstudio.com/_git/binaries
ghost
added
the
|
Learn Build status updates of commit 6b8114c:
|
| @@ -3,7 +3,7 @@ | |||
| <TypeSignature Language="ILAsm" Value=".class public auto ansi beforefieldinit SynchronizedCollection`1<T> extends System.Object implements class System.Collections.Generic.ICollection`1<!T>, class System.Collections.Generic.IEnumerable`1<!T>, class System.Collections.Generic.IList`1<!T>, class System.Collections.ICollection, class System.Collections.IEnumerable, class System.Collections.IList" /> | |||
| <TypeSignature Language="DocId" Value="T:System.Collections.Generic.SynchronizedCollection`1" /> | |||
| <TypeSignature Language="VB.NET" Value="Public Class SynchronizedCollection(Of T)
Implements ICollection(Of T), IEnumerable(Of T), IList, IList(Of T)" /> | |||
| <TypeSignature Language="F#" Value="type SynchronizedCollection<'T> = class
 interface IList<'T>
 interface ICollection<'T>
 interface seq<'T>
 interface IEnumerable
 interface IList
 interface ICollection" FrameworkAlternate="net-8.0;netframework-4.6;netframework-4.6.1;netframework-4.6.2;netframework-4.7;netframework-4.7.1;netframework-4.7.2;netframework-4.8;netframework-4.8.1;netstandard-2.0" /> | |||
| <TypeSignature Language="F#" Value="type SynchronizedCollection<'T> = class
 interface IList<'T>
 interface ICollection<'T>
 interface seq<'T>
 interface IEnumerable
 interface IList
 interface ICollection" FrameworkAlternate="net-8.0;netframework-4.6;netframework-4.6.1;netframework-4.6.2;netframework-4.7;netframework-4.7.1;netframework-4.7.2;netframework-4.8;netframework-4.8.1" /> | |||
There was a problem hiding this comment.
Something still seems a bit off here. SynchronizedCollection is available for netstandard-2.0 in the 4.10.3 version of System.ServiceModel.Primitives. netstandard-2.0 support will be coming back in the latest packages soon.
| <TypeSignature Language="DocId" Value="T:System.IdentityModel.Selectors.SecurityTokenResolver" /> | ||
| <TypeSignature Language="VB.NET" Value="Public MustInherit Class SecurityTokenResolver" FrameworkAlternate="net-8.0;netframework-3.0;netframework-3.5;netframework-4.0;netstandard-2.0" /> |
There was a problem hiding this comment.
What does it mean for netstandard-2.0 to be removed here? SecurityTokenResolver is available for netstandard2.0 from System.ServiceModel.Primitives in 4.10.3
There was a problem hiding this comment.
The package indexer tool only considers the latest stable (and latest preview version, if it's newer), which for System.ServiceModel.Primitives is 8.0.0. Is there a need to index 4.10.3 as well?
There was a problem hiding this comment.
For now there is. We've extended support because we removed netstandard2.0 support from 8.0.0 and turns out it was more important than we were told so we're bringing it back. For now the 4.10.3 package is what you use if you need netstandard2.0 support.
There was a problem hiding this comment.
Okay, I'll special case it.
There was a problem hiding this comment.
@mconnew I'm having a hard time ingesting the System.ServiceModel.Primitives 4.10.3 package for .NET Standard. I tried with both the lib and ref assemblies, and both times got:
##[error]mdoc: Mono.Documentation.MDocAssemblyException: Error caching System.ServiceModel, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089 from D:\a_work\1\s\source_repo\dotnet\netstandard-2.0\System.ServiceModel.dll ---> Mono.Documentation.MDocException: Failed to resolve type 'System.ServiceModel.BasicHttpBinding' ---> Mono.Cecil.AssemblyResolutionException: Failed to resolve assembly: 'System.ServiceModel.Http, Version=4.10.3.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
at Mono.Documentation.Updater.Frameworks.MDocBaseResolver.Resolve(AssemblyNameReference name, ReaderParameters parameters, IEnumerable`1 filesToIgnore)
Should I also ingest this package for the documentation? https://www.nuget.org/packages/System.ServiceModel.Http/4.10.3
There was a problem hiding this comment.
Update: I added System.ServiceModel.Http, but now getting an error for a dependency on System.ServiceModel.Duplex:
##[error]mdoc: Mono.Documentation.MDocAssemblyException: Error caching System.ServiceModel, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089 from D:\a_work\1\s\source_repo\dotnet\netstandard-2.0\System.ServiceModel.dll ---> Mono.Documentation.MDocException: Failed to resolve type 'System.ServiceModel.CallbackBehaviorAttribute' ---> Mono.Cecil.AssemblyResolutionException: Failed to resolve assembly: 'System.ServiceModel.Duplex, Version=4.10.3.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
Build.Reason:Manual by Genevieve Warren
Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=441514&view=results
source_repo.branch:remove-systemprivateservicemodel
source_repo.url:https://apidrop.visualstudio.com/_git/binaries
Remove System.Private.ServiceModel package from .NET Standard 2.0. See #10157 (comment).