Skip to content

Fix supported schemes in docs #10600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Conversation

deeprobin
Copy link
Contributor

Summary

Documentation enhanced to include the supported proxy formats:

  • https
  • socks4
  • socks4a
  • socks5

Fixes dotnet/runtime#102441

/cc @MihaZupan

@deeprobin deeprobin requested a review from a team as a code owner October 21, 2024 19:10
@ghost ghost added the area-System.Net.Http label Oct 21, 2024
@deeprobin
Copy link
Contributor Author

@MihaZupan Should I comment the different behaviors in .NET 7 and 8 or is the documentation here only for the current/upcoming .NET releease (so .NET 10)?

Copy link

Learn Build status updates of commit c9a4338:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Http/HttpClient.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Oct 21, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl

Copy link
Member

@MihaZupan MihaZupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the delayed review, but thank you for improving this

@MihaZupan MihaZupan enabled auto-merge (squash) October 30, 2024 22:01
Copy link

Learn Build status updates of commit fb5a470:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Http/HttpClient.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@MihaZupan MihaZupan merged commit 0121963 into dotnet:main Oct 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Net.Http community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpClient doesn't support proxy server in HTTPS protocol in Linux
2 participants