Skip to content

Corrected wrong value of ClientCertificateOptions #10608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

bb-froggy
Copy link
Contributor

Summary

The value of ClientCertificateOptions was described as a collection of security certificates. This is was a copy-and-paste mistake where the value was copied from ClientCertificates.

This correctly describes the value of one of the enum values.

@bb-froggy bb-froggy requested a review from a team as a code owner October 25, 2024 13:33
@ghost ghost added the area-System.Net.Http label Oct 25, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Oct 25, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl

Copy link

Learn Build status updates of commit 73e49b4:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Http/HttpClientHandler.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Member

@CarnaViire CarnaViire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Co-authored-by: Genevieve Warren <[email protected]>
@MihaZupan MihaZupan enabled auto-merge (squash) October 30, 2024 20:19
Copy link

Learn Build status updates of commit ad85af7:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Http/HttpClientHandler.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@MihaZupan MihaZupan merged commit f68c257 into dotnet:main Oct 30, 2024
4 checks passed
@bb-froggy bb-froggy deleted the patch-1 branch October 31, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Net.Http community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants