Skip to content

Fix example output of BigInteger(Int64) #11035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 3, 2025
Merged

Fix example output of BigInteger(Int64) #11035

merged 4 commits into from
Mar 3, 2025

Conversation

Rageking8
Copy link
Contributor

Summary

Fix output of example for BigInteger(Int64) constructor.

Fixes #10346.

@Rageking8 Rageking8 requested a review from a team as a code owner March 1, 2025 10:51
@ghost ghost added the area-System.Numerics label Mar 1, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Mar 1, 2025
@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit 0acaa28:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/System.Numerics/BigInteger/.ctor/Example2.cs ✅Succeeded View
snippets/fsharp/System.Numerics/BigInteger/.ctor/Example2.fs ✅Succeeded View
snippets/visualbasic/VS_Snippets_CLR_System/system.Numerics.BigInteger.ctors/vb/Example2.vb ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit a943054:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/System.Numerics/BigInteger/.ctor/Example2.cs ✅Succeeded View
snippets/csharp/System.Numerics/BigInteger/.ctor/Project.csproj ✅Succeeded
snippets/fsharp/System.Numerics/BigInteger/.ctor/Example2.fs ✅Succeeded View
snippets/visualbasic/VS_Snippets_CLR_System/system.Numerics.BigInteger.ctors/vb/Example2.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_CLR_System/system.Numerics.BigInteger.ctors/vb/Project.vbproj ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit 06d30e8:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/System.Numerics/BigInteger/.ctor/Example1.cs ✅Succeeded View
snippets/csharp/System.Numerics/BigInteger/.ctor/Example2.cs ✅Succeeded View
snippets/csharp/System.Numerics/BigInteger/.ctor/Project.csproj ✅Succeeded
snippets/fsharp/System.Numerics/BigInteger/.ctor/Example2.fs ✅Succeeded View
snippets/visualbasic/VS_Snippets_CLR_System/system.Numerics.BigInteger.ctors/vb/Example1.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_CLR_System/system.Numerics.BigInteger.ctors/vb/Example2.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_CLR_System/system.Numerics.BigInteger.ctors/vb/Project.vbproj ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

BillWagner
BillWagner approved these changes Mar 3, 2025
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @Rageking8

I did make a couple small suggestions to use .NET 9 instead of .NET 6. Then, I'll merge this.

snippets/visualbasic/VS_Snippets_CLR_System/system.Numerics.BigInteger.ctors/vb/Project.vbproj Outdated
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<OutputType>Library</OutputType>
<TargetFramework>net6.0</TargetFramework>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same:

Suggested change
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net9.0</TargetFramework>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the extra newline here intentional?

@BillWagner BillWagner enabled auto-merge (squash) March 3, 2025 15:49
@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit 2c529c8:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/System.Numerics/BigInteger/.ctor/Example1.cs ✅Succeeded View
snippets/csharp/System.Numerics/BigInteger/.ctor/Example2.cs ✅Succeeded View
snippets/csharp/System.Numerics/BigInteger/.ctor/Project.csproj ✅Succeeded
snippets/fsharp/System.Numerics/BigInteger/.ctor/Example2.fs ✅Succeeded View
snippets/visualbasic/VS_Snippets_CLR_System/system.Numerics.BigInteger.ctors/vb/Example1.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_CLR_System/system.Numerics.BigInteger.ctors/vb/Example2.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_CLR_System/system.Numerics.BigInteger.ctors/vb/Project.vbproj ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@BillWagner BillWagner merged commit 2d62b56 into dotnet:main Mar 3, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees
No one assigned
Labels
area-System.Numerics community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Small error in BigInteger(Int64) constructor example
2 participants
@Rageking8 @BillWagner