Skip to content

Make SHA algorithm names more consistent #11104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 18, 2025
Merged

Conversation

gewarren
Copy link
Contributor

Use SHA-256 for algorithm. Use SHA256 for class name. See guidance.

(Hide whitespace changes.)

Fixes #11023. Replaces #11062.

@gewarren gewarren requested review from a team, HongGit and mconnew as code owners March 18, 2025 19:06
@github-actions github-actions bot added the area-System.Security Issues related to security practices for .NET developers. label Mar 18, 2025
@gewarren gewarren mentioned this pull request Mar 18, 2025
Copy link
Contributor

@gewarren - This PR edits one or more files whose 'source of truth' for documentation is not in this repo. Please make documentation updates in the /// comments in the dotnet/runtime repo (or dotnet/extensions repo) instead.

@gewarren
Copy link
Contributor Author

@gewarren - This PR edits one or more files whose 'source of truth' for documentation is not in this repo. Please make documentation updates in the /// comments in the dotnet/runtime repo (or dotnet/extensions repo) instead.

Updated in source too: dotnet/extensions#6149

This comment was marked as outdated.

Copy link

Learn Build status updates of commit 6a8c940:

✅ Validation status: passed

File Status Preview URL Details
xml/Microsoft.Extensions.Compliance.Redaction/HmacRedactor.xml ✅Succeeded View
xml/System.CodeDom/CodeChecksumPragma.xml ✅Succeeded View
xml/System.Configuration.Assemblies/AssemblyHashAlgorithm.xml ✅Succeeded View
xml/System.IdentityModel.Tokens/InMemorySymmetricSecurityKey.xml ✅Succeeded View
xml/System.IdentityModel.Tokens/SecurityAlgorithms.xml ✅Succeeded View
xml/System.IdentityModel.Tokens/SymmetricSecurityKey.xml ✅Succeeded View
xml/System.IdentityModel.Tokens/X509AsymmetricSecurityKey.xml ✅Succeeded View
xml/System.IdentityModel/RsaEncryptionCookieTransform.xml ✅Succeeded View
xml/System.IdentityModel/RsaSignatureCookieTransform.xml ✅Succeeded View
xml/System.IO.Packaging/PackageDigitalSignatureManager.xml ✅Succeeded View
xml/System.Messaging/DefaultPropertiesToSend.xml ✅Succeeded View
xml/System.Messaging/Message.xml ✅Succeeded View
xml/System.Net.Http.Headers/HttpContentHeaders.xml ✅Succeeded View
xml/System.Net/HttpRequestHeader.xml ✅Succeeded View
xml/System.Net/HttpResponseHeader.xml ✅Succeeded View
xml/System.Reflection.Metadata/Document.xml ✅Succeeded View
xml/System.Reflection.PortableExecutable/PdbChecksumDebugDirectoryData.xml ✅Succeeded View
xml/System.Reflection/Assembly.xml ✅Succeeded View
xml/System.Reflection/AssemblyHashAlgorithm.xml ✅Succeeded View
xml/System.Security.Authentication/HashAlgorithmType.xml ✅Succeeded View
xml/System.Security.Cryptography.Pkcs/Pkcs12Builder.xml ✅Succeeded View
xml/System.Security.Cryptography.X509Certificates/X509Certificate.xml ✅Succeeded View
xml/System.Security.Cryptography.Xml/Reference.xml ✅Succeeded View
xml/System.Security.Cryptography.Xml/SignedInfo.xml ✅Succeeded View
xml/System.Security.Cryptography.Xml/SignedXml.xml ✅Succeeded View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

@gewarren gewarren merged commit 31b4b09 into dotnet:main Mar 18, 2025
4 checks passed
@gewarren gewarren deleted the sha-naming branch March 18, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Security Issues related to security practices for .NET developers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent spelling of HMAC SHA256 in Microsoft documentation
2 participants