Skip to content

Fix typo in CharUnicodeInfo.xml #11424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025
Merged

Fix typo in CharUnicodeInfo.xml #11424

merged 2 commits into from
Jun 11, 2025

Conversation

ericmutta
Copy link
Contributor

Summary

The following:

The UnicodeCategory class ...

Should read:

The UnicodeCategory enumeration ...

The following:
>  The UnicodeCategory **class**

Should read:
>  The UnicodeCategory **enumeration**
@ericmutta ericmutta requested a review from a team as a code owner June 10, 2025 13:16
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 10, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jun 10, 2025
@BillWagner BillWagner requested a review from gewarren June 10, 2025 15:42
@BillWagner
Copy link
Member

Adding @gewarren

This Looks great, but I didn't know if we generally use "enumeration" or "enum".

@ericmutta
Copy link
Contributor Author

Hey @BillWagner thanks for following up. I was curious about that too. I checked the remarks for the actual enum and I can see it uses the longer "enumeration" so I went with that:

A member of the UnicodeCategory enumeration is returned...The UnicodeCategory enumeration is also...

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I left a couple suggestions.

@dotnet-policy-service dotnet-policy-service bot removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 10, 2025
Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with @gewarren suggestion.

@ericmutta
Copy link
Contributor Author

Thanks @gewarren and @tarekgh for following up...Unicode is a complicated business and these docs make it much easier to understand 🚀

Co-authored-by: Genevieve Warren <[email protected]>
@tarekgh tarekgh merged commit aca02aa into dotnet:main Jun 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Globalization community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants