-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Fix typo in CharUnicodeInfo.xml #11424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The following: > The UnicodeCategory **class** Should read: > The UnicodeCategory **enumeration**
Adding @gewarren This Looks great, but I didn't know if we generally use "enumeration" or "enum". |
Hey @BillWagner thanks for following up. I was curious about that too. I checked the remarks for the actual enum and I can see it uses the longer "enumeration" so I went with that:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I left a couple suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with @gewarren suggestion.
Co-authored-by: Genevieve Warren <[email protected]>
Summary
The following:
Should read: