Skip to content

Add docs for Microsoft.Extensions.DependencyModel.Library and subclasses #8327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 17, 2024

Conversation

MSDN-WhiteKnight
Copy link
Contributor

Issue: #3418

Add API docs for Microsoft.Extensions.DependencyModel.*Library classes and example for CompilationLibrary. Based on .deps.json specification and source code.

@MSDN-WhiteKnight MSDN-WhiteKnight requested a review from a team as a code owner August 21, 2022 08:58
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Aug 21, 2022
@ghost
Copy link

ghost commented Aug 21, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@opbld33
Copy link

opbld33 commented Aug 21, 2022

Docs Build status updates of commit 71d5704:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/Microsoft.Extensions.DependencyModel/CompilationLibrary/Overview/CompilationLibrarySnippets.cs ✅Succeeded View
snippets/csharp/Microsoft.Extensions.DependencyModel/CompilationLibrary/Overview/CompilationLibrarySnippets.csproj ✅Succeeded
snippets/csharp/Microsoft.Extensions.DependencyModel/CompilationLibrary/Overview/Program.cs ✅Succeeded
xml/Microsoft.Extensions.DependencyModel/CompilationLibrary.xml ✅Succeeded View
xml/Microsoft.Extensions.DependencyModel/Library.xml ✅Succeeded View
xml/Microsoft.Extensions.DependencyModel/RuntimeLibrary.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@BillWagner
Copy link
Member

ping @jeffhandley

There isn't a label in this repo for the "area-DependencyModel" to help fabric bot. How should we get the correct label and reviewers assigned?

@jozkee
Copy link
Member

jozkee commented Sep 26, 2022

@eiriktsarpalis @joperezr, do you know how to add the missing label @BillWagner mentions?

@eiriktsarpalis
Copy link
Member

It should take a couple of steps:

  1. Creating the area label manually for the repo.
  2. Add an entry in the corresponding rule in the repo's fabricbot.json file. If memory serves this rule is being updated manually, but if not there might be a relevant script in the fabricbot-config repo. @jeffhandley or @ericstj might know for sure.

@ghost
Copy link

ghost commented Sep 27, 2022

Tagging subscribers to this area: @dotnet/area-dependencymodel
See info in area-owners.md if you want to be subscribed.

Issue Details

Issue: #3418

Add API docs for Microsoft.Extensions.DependencyModel.*Library classes and example for CompilationLibrary. Based on .deps.json specification and source code.

Author: MSDN-WhiteKnight
Assignees: -
Labels:

community-contribution, area-DependencyModel

Milestone: -

@ericstj
Copy link
Member

ericstj commented Sep 27, 2022

It only requires the first step as it looks like the fabricbot configuration already accounts for the labels. Anyone with write permission in the repo can create a label. I just did so and applied it here.

@gewarren gewarren requested a review from a team June 5, 2024 19:29
@ViktorHofer
Copy link
Member

@gewarren and @MSDN-WhiteKnight sorry for the long delay, I didn't get pinged on this until recently. I just reviewed and the doc additions look great. Thanks a lot @MSDN-WhiteKnight.

@ViktorHofer ViktorHofer enabled auto-merge (squash) July 17, 2024 09:02
Copy link

@ViktorHofer ViktorHofer merged commit 5afc064 into dotnet:main Jul 17, 2024
3 checks passed
@MSDN-WhiteKnight MSDN-WhiteKnight deleted the library-docs branch July 18, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-DependencyModel community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants