Skip to content

Update value of mono cconv enum #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

BrzVlad
Copy link
Member

@BrzVlad BrzVlad commented Jul 4, 2024

Value changed within llvm at https://github.com/dotnet/llvm-project/blob/dotnet/main-19.x/llvm/include/llvm/IR/CallingConv.h#L93. LLVMMono1CallConv is used by the mini llvm backend when generating code.

@akoeplinger
Copy link
Member

Should we bump to some higher value right away so we don't risk conflicting with future llvm changes again?

@BrzVlad
Copy link
Member Author

BrzVlad commented Jul 5, 2024

Let's keep it in mind to do it next time if conflicts still happen.

@akoeplinger akoeplinger merged commit e5c221b into dotnet:dotnet/main-19.x Jul 5, 2024
15 checks passed
radekdoulik pushed a commit that referenced this pull request Aug 16, 2024
radekdoulik pushed a commit that referenced this pull request Sep 2, 2024
radekdoulik pushed a commit that referenced this pull request Sep 12, 2024
radekdoulik pushed a commit that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants