Skip to content

Fix all code that has //REVIEW against it #3704

Open
@vinodshanbhag

Description

@vinodshanbhag

C:\code\MLNet\src\Microsoft.ML.Auto\ColumnInference\ColumnTypeInference.cs(20): // REVIEW: revisit this requirement. Either work for arbitrary number of columns,
C:\code\MLNet\src\Microsoft.ML.Auto\ColumnInference\PurposeInference.cs(228): // REVIEW: could be improved.
C:\code\MLNet\src\Microsoft.ML.Auto\ColumnInference\TextFileSample.cs(18): // REVIEW: consider including multiple files via IMultiStreamSource.
C:\code\MLNet\src\Microsoft.ML.Auto\ColumnInference\TextFileSample.cs(20): // REVIEW: right now, it expects 0x0A being the trailing character of line break.
C:\code\MLNet\src\Microsoft.ML.Auto\ColumnInference\TextFileSample.cs(110): // REVIEW: CreateFromHead still truncates the file before the last 0x0A byte. For multi-byte encoding,
C:\code\MLNet\src\Microsoft.ML.Auto\Sweepers\Parameters.cs(205): // REVIEW: this condition can be relaxed if we change the math below to deal with it
C:\code\MLNet\src\Microsoft.ML.Auto\Sweepers\Parameters.cs(212): // REVIEW: Is Float accurate enough?
C:\code\MLNet\src\Microsoft.ML.Auto\Sweepers\Parameters.cs(218): // REVIEW: review the math below, it only works for positive Min and Max
C:\code\MLNet\src\Microsoft.ML.Auto\Sweepers\Parameters.cs(248): // REVIEW: review the math below, it only works for positive Min and Max
C:\code\MLNet\src\Microsoft.ML.Auto\Sweepers\Parameters.cs(331): // REVIEW: this condition can be relaxed if we change the math below to deal with it
C:\code\MLNet\src\Microsoft.ML.Auto\Sweepers\Parameters.cs(338): // REVIEW: Is Float accurate enough?
C:\code\MLNet\src\Microsoft.ML.Auto\Sweepers\Parameters.cs(344): // REVIEW: review the math below, it only works for positive Min and Max
C:\code\MLNet\src\Microsoft.ML.Auto\Sweepers\Parameters.cs(366): // REVIEW: review the math below, it only works for positive Min and Max
C:\code\MLNet\src\Microsoft.ML.Auto\Sweepers\Parameters.cs(451): // REVIEW: Is Float accurate enough?
C:\code\MLNet\src\Microsoft.ML.Auto\Sweepers\SmacSweeper.cs(15): //REVIEW: Figure out better way to do this. could introduce a base class for all smart sweepers,
C:\code\MLNet\src\Microsoft.ML.Auto\Utils\MLNetUtils\ArrayDataViewBuilder.cs(229): // REVIEW: Implement cursor set support.
C:

Metadata

Metadata

Assignees

No one assigned

    Labels

    AutoML.NETAutomating various steps of the machine learning processP2Priority of the issue for triage purpose: Needs to be fixed at some point.code-sanitationCode consistency, maintainability, and best practices, moreso than any public API.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions