[main] Update self-reference for RC1 release #782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelSimons
requested review from
mthalman and
oleksandr-didyk
as code owners
mthalman
reviewed
Sep 13, 2023
Comment on lines
+9
to
+11
| <Dependency Name="Microsoft.SourceBuild.Intermediate.source-build-reference-packages" Version="8.0.0-alpha.1.23414.1"> | ||
| <Uri>https://github.com/dotnet/source-build-reference-packages</Uri> | ||
| <Sha>529fbc2aad419d0c1551d6685cc68be33e62a996</Sha> | ||
| <Sha>45f5554ac6813e1e155c47fd80ec146c684f65e8</Sha> |
There was a problem hiding this comment.
This should probably be updated to reflect the package from the new 9.0 channel.
There was a problem hiding this comment.
No, it shouldn't until there is a release from main. Main is or will be building soon with the rc1 SDK and this is the version it shipped with. This would cause a type of incoherency.
mthalman
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port #780 to main.