Skip to content

Manually update Microsoft.Private.Intellisense to 8.0.0-preview-20230918.1 #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Manually update Microsoft.Private.Intellisense to 8.0.0-preview-20230918.1 #787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
737b20a
Add 8.0.0-preview-20230918.1
carlossanlop Sep 18, 2023
eed2680
Delete 8.0.0-preview-20230828.1
carlossanlop Sep 18, 2023
a08a506
Update Build.props DependencyPackageProjects version.
carlossanlop Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
Format:
<DependencyPackageProjects Include="$(RepoRoot)src\referencePackages\src\**\Microsoft.Extensions.Options.5.0.0.csproj" />
-->
<DependencyPackageProjects Include="$(RepoRoot)src\textOnlyPackages\src\microsoft.private.intellisense\8.0.0-preview-20230828.1\Microsoft.Private.Intellisense.8.0.0-preview-20230828.1.csproj" />
<DependencyPackageProjects Include="$(RepoRoot)src\textOnlyPackages\src\microsoft.private.intellisense\8.0.0-preview-20230918.1\Microsoft.Private.Intellisense.8.0.0-preview-20230918.1.csproj" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MichaelSimons - For a version upgrade like this, is this acceptable to change the version in Build.props like this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally no but it is OK for this package because we know no other SBRP packages reference it.


<DependencyPackageProjects Include="$(RepoRoot)src\targetPacks\ILsrc\**\Microsoft.NETCore.App.Ref.6.0.2.csproj" />
<DependencyPackageProjects Include="$(RepoRoot)src\targetPacks\ILsrc\**\Microsoft.AspNetCore.App.Ref.6.0.2.csproj" />
Expand Down
18 changes: 0 additions & 18 deletions ...ew-20230828.1/IntellisenseFiles/dotnet-plat-ext/1033/Microsoft.Extensions.Diagnostics.xml
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions ...xtensions.AmbientMetadata.Application.xml → ...xtensions.AmbientMetadata.Application.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
<param name="services">The dependency injection container to add the instance to.</param>
<param name="section">The configuration section to bind.</param>
<exception cref="T:System.ArgumentNullException">
<paramref name="section" /> or <paramref name="section" /> are <see langword="null" />.</exception>
<paramref name="section" /> or <paramref name="section" /> is <see langword="null" />.</exception>
<returns>The value of <paramref name="services" />&gt;.</returns>
</member>
<member name="M:Microsoft.Extensions.AmbientMetadata.ApplicationMetadataExtensions.AddApplicationMetadata(Microsoft.Extensions.DependencyInjection.IServiceCollection,System.Action{Microsoft.Extensions.AmbientMetadata.ApplicationMetadata})">
Expand All @@ -56,7 +56,7 @@
<param name="services">The dependency injection container to add the instance to.</param>
<param name="configure">The delegate to configure <see cref="T:Microsoft.Extensions.AmbientMetadata.ApplicationMetadata" /> with.</param>
<exception cref="T:System.ArgumentNullException">
<paramref name="services" /> or <paramref name="configure" /> are <see langword="null" />.</exception>
<paramref name="services" /> or <paramref name="configure" /> is <see langword="null" />.</exception>
<returns>The value of <paramref name="services" />&gt;.</returns>
</member>
<member name="M:Microsoft.Extensions.AmbientMetadata.ApplicationMetadataExtensions.UseApplicationMetadata(Microsoft.Extensions.Hosting.IHostBuilder,System.String)">
Expand Down
8 changes: 0 additions & 8 deletions .../1033/Microsoft.Extensions.AsyncState.xml → .../1033/Microsoft.Extensions.AsyncState.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,6 @@
<paramref name="services" /> is <see langword="null" />.</exception>
<returns>The value of <paramref name="services" />.</returns>
</member>
<member name="M:Microsoft.Extensions.AsyncState.AsyncStateExtensions.TryRemoveAsyncStateCore(Microsoft.Extensions.DependencyInjection.IServiceCollection)">
<summary>
Tries to remove the default implementation for <see cref="T:Microsoft.Extensions.AsyncState.IAsyncState" />, <see cref="T:Microsoft.Extensions.AsyncState.IAsyncContext`1" />, and <see cref="T:Microsoft.Extensions.AsyncState.IAsyncLocalContext`1" /> services.</summary>
<param name="services">The dependency injection container to remove the implementations from.</param>
<exception cref="T:System.ArgumentNullException">
<paramref name="services" /> is <see langword="null" />.</exception>
<returns>The value of <paramref name="services" />.</returns>
</member>
<member name="T:Microsoft.Extensions.AsyncState.AsyncStateToken">
<summary>
Async state token representing a registered context within the asynchronous state.</summary>
Expand Down
Loading