-
-
Notifications
You must be signed in to change notification settings - Fork 347
feat(Bootstrap): support dynamic load bootstrap javascript #6201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideIntroduces dynamic loading of the Bootstrap JavaScript bundle by injecting ES module imports into all relevant client-side scripts and removes the now redundant static script reference. Sequence Diagram: Dynamic Bootstrap JS Loading via ES ImportssequenceDiagram
actor Browser
participant AppPage as "HTML Page (from App.razor)"
participant ComponentModule as "JS Module (e.g., Button.razor.js)"
participant BootstrapBundle as "bootstrap.blazor.bundle.min.js"
Browser->>AppPage: GET / (Request initial page)
AppPage-->>Browser: HTML (references ComponentModule)
Browser->>ComponentModule: GET ComponentModule
activate ComponentModule
ComponentModule->>BootstrapBundle: ES6 import (triggers GET BootstrapBundle)
activate BootstrapBundle
BootstrapBundle-->>ComponentModule: Module code returned
deactivate BootstrapBundle
ComponentModule-->>Browser: Module execution completes (with Bootstrap functionality)
deactivate ComponentModule
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6201 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 704 704
Lines 31100 31100
Branches 4394 4394
=========================================
Hits 31100 31100
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6200
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enable dynamic loading of the BootstrapBlazor JavaScript bundle across components and remove the static script include to fix issue #6200.
Bug Fixes:
Enhancements: