Skip to content

Catch socket.errors when sending / recving bytes on wake socketpair #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions kafka/client_async.py
Original file line number Diff line number Diff line change
Expand Up @@ -829,15 +829,17 @@ def check_version(self, node_id=None, timeout=2, strict=False):

def wakeup(self):
with self._wake_lock:
if self._wake_w.send(b'x') != 1:
try:
assert self._wake_w.send(b'x') == 1
except (AssertionError, socket.error):
log.warning('Unable to send to wakeup socket!')

def _clear_wake_fd(self):
# reading from wake socket should only happen in a single thread
while True:
try:
self._wake_r.recv(1024)
except:
except socket.error:
break


Expand Down