Support for multiple hosts on KafkaClient boostrap (improves on #70) #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: kafka/client.py kafka/conn.py setup.py test/test_integration.py test/test_unit.py
|
|
||
| res = host_port.split(':') | ||
| host = res[0] | ||
| port = int(res[1]) if len(res) > 1 else 9092 |
There was a problem hiding this comment.
Default port should be a constant: DEFAULT_KAKFA_PORT = 9092
|
Looks good! I just had a couple of minor comments. Thanks for all the unit test work! |
| result = [] | ||
| for host_port in hosts: | ||
|
|
||
| res = host_port.split(':') |
There was a problem hiding this comment.
You probably want host_port.strip().split(':') to allow for spaces around the commas
rdiomar
added a commit
that referenced
this pull request
Feb 27, 2014
Support for multiple hosts on KafkaClient boostrap (improves on #70)
susman
pushed a commit
to liquidm/collectd2kafka
that referenced
this pull request
Jul 7, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow KafkaClient to take in a list of brokers for bootstrapping (improves in #70)
Proposed resolution for enhancement #25
This change breaks the KafkaClient constructor API but replacing the host and port parameters with hosts represented as a comma-separated list of host:port.
E.g. as comma-separated string of host:port
kafka = KafkaClient("localhost:9092, localhost:9093")or as list of host:port
kafka = KafkaClient(['localhost:9092', 'localhost:9093'])It also introduces the mock library for unit testing.
Note: some unit tests are still marked as skipped until disabling recursion on
load_metadata_for_topics_, an issue I found during testing (#68). They are enabled in #109