Skip to content

Fix flaky conn tests that use time.time #1758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2019
Merged

Fix flaky conn tests that use time.time #1758

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions test/test_conn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,18 +74,21 @@ def test_connect_timeout(_socket, conn):


def test_blacked_out(conn):
assert conn.blacked_out() is False
conn.last_attempt = time.time()
assert conn.blacked_out() is True
with mock.patch("time.time", return_value=1000):
conn.last_attempt = 0
assert conn.blacked_out() is False
conn.last_attempt = 1000
assert conn.blacked_out() is True


def test_connection_delay(conn):
conn.last_attempt = time.time()
assert round(conn.connection_delay()) == round(conn.config['reconnect_backoff_ms'])
conn.state = ConnectionStates.CONNECTING
assert conn.connection_delay() == 0
conn.state = ConnectionStates.CONNECTED
assert conn.connection_delay() == float('inf')
with mock.patch("time.time", return_value=1000):
conn.last_attempt = 1000
assert conn.connection_delay() == conn.config['reconnect_backoff_ms']
conn.state = ConnectionStates.CONNECTING
assert conn.connection_delay() == 0
conn.state = ConnectionStates.CONNECTED
assert conn.connection_delay() == float('inf')


def test_connected(conn):
Expand Down