Adding codec abstraction for compatibility #179
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Codec` class has been added to support Snappy-Xerial compatibility in the Producer. Without this, Java-based consumers will be unable to decode messages produced by non-Xerial Snappy producers.
| payloads: list(bytes), a list of payload to send be sent to Kafka | ||
| key: bytes, a key used for partition routing (optional) | ||
| """ | ||
| def create_encoded_message(messages, codec=CODEC_NONE): |
There was a problem hiding this comment.
We lost the ability to specify a key here?
dpkp
force-pushed
the
master
branch
2 times, most recently
from
b5e3a14 to
4955582
Compare
|
Closing - by default all snappy encoded messages are now xerial-compatible, so this should no longer be an issue. |
orange-kao
pushed a commit
to orange-kao/kafka-python
that referenced
this pull request
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Codecclass has been added to support Snappy-Xerial compatibility in the Producer. Without this, Java-based consumers will be unable to decode messages produced by non-Xerial Snappy producers.