Skip to content

Remove unused import #1808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions kafka/cluster.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
from kafka.vendor import six

from kafka import errors as Errors
from kafka.conn import collect_hosts, dns_lookup
from kafka.conn import collect_hosts
from kafka.future import Future
from kafka.structs import BrokerMetadata, PartitionMetadata, TopicPartition

Expand Down Expand Up @@ -189,7 +189,7 @@ def request_update(self):
with self._lock:
self._need_update = True
if not self._future or self._future.is_done:
self._future = Future()
self._future = Future()
return self._future

def topics(self, exclude_internal_topics=True):
Expand Down
6 changes: 1 addition & 5 deletions test/test_client_async.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,24 +17,20 @@
from kafka.conn import ConnectionStates
import kafka.errors as Errors
from kafka.future import Future
from kafka.protocol.metadata import MetadataResponse, MetadataRequest
from kafka.protocol.metadata import MetadataRequest
from kafka.protocol.produce import ProduceRequest
from kafka.structs import BrokerMetadata


@pytest.fixture
def cli(mocker, conn):
mocker.patch('kafka.cluster.dns_lookup',
return_value=[(socket.AF_INET, None, None, None, ('localhost', 9092))])
client = KafkaClient(api_version=(0, 9))
client.poll(future=client.cluster.request_update())
return client


def test_bootstrap(mocker, conn):
conn.state = ConnectionStates.CONNECTED
mocker.patch('kafka.cluster.dns_lookup',
return_value=[(socket.AF_INET, None, None, None, ('localhost', 9092))])
cli = KafkaClient(api_version=(0, 9))
future = cli.cluster.request_update()
cli.poll(future=future)
Expand Down