Remove string support in api_version
#1814
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
force-pushed
the
Remove-support-for-api_version-strings
branch
from
eb33f61 to
c463b1c
Compare
A long time ago, `api_version` supported strings. That has been deprecated for years in favor of tuples. Time to remove support for the strings.
jeffwidman
force-pushed
the
Remove-support-for-api_version-strings
branch
from
c463b1c to
b6c6a27
Compare
|
What do we gain by removing this? I understand the desire to keep code clean, but is there a specific feature that is blocked by keeping this in ? |
|
Agreed. And personally I think the string value is a sensible enough choice, even though it is error prone. I also noticed that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks backwards compatibility, probably best not to merge 'til
2.0releaseA long time ago,
api_versionsupported strings. That has beendeprecated for years in favor of tuples. Time to remove support for the
strings.
This change is