Skip to content

Remove some unused code #1925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2020
Merged

Remove some unused code #1925

merged 1 commit into from
Feb 5, 2020

Conversation

jeffwidman
Copy link
Contributor

@jeffwidman jeffwidman commented Oct 11, 2019

Currently these are TODO's, but hopefully @dpkp can provide backstory on whether to remove these or leave them in...


This change is Reviewable

@jeffwidman jeffwidman force-pushed the remove-some-unused-code branch from 97b0e05 to 1e1b13d Compare October 11, 2019 19:35
@@ -114,6 +114,7 @@ def queued(self):
with self._lock:
return len(self._waiters)

# TODO should this be removed or finished?
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine to remove. Memory allocation is not a bottleneck as far as I can tell.

@@ -65,6 +65,7 @@ def __eq__(self, other):
return False
return True

# TODO should this be removed or finished?
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep -- remove

kafka/util.py Outdated
@@ -67,6 +67,7 @@ class Dict(dict):
pass


# TODO what is the purpose of this? It has been unused since it was originally added
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about using this to help prevent circular references when calling instance methods with atexit . Currently we only do that in the producer, and we use weakproxy directly. If we ever needed to do a similar cleanup for other classes then this method might be helpful. But I don't mind if you delete it.

Repository owner deleted a comment from dpkp Feb 5, 2020
@jeffwidman jeffwidman force-pushed the remove-some-unused-code branch from 1e1b13d to 1dace1d Compare February 5, 2020 23:54
@jeffwidman jeffwidman force-pushed the remove-some-unused-code branch from 1dace1d to ca2d763 Compare February 5, 2020 23:56
@jeffwidman jeffwidman merged commit 6babefa into master Feb 5, 2020
@jeffwidman jeffwidman deleted the remove-some-unused-code branch February 5, 2020 23:57
jeffwidman added a commit that referenced this pull request Feb 6, 2020
Forgot to remove this in #1925
/ ca2d763
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants