Skip to content

Topics management #1956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

TylerLubeck
Copy link
Contributor

@TylerLubeck TylerLubeck commented Nov 15, 2019

Utilize new object creation to implement metadata based admin commands.

This is based on work done in #1951 and includes those commits.


This change is Reviewable

Copy link
Owner

@dpkp dpkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice -- you went on a tear!

@jeffwidman
Copy link
Contributor

@TylerLubeck can you fix merge conflicts? Be nice to land this now that #1951 is in...

@TylerLubeck
Copy link
Contributor Author

Moved to #1993 so that the PR is just the changes intended

@TylerLubeck TylerLubeck closed this Feb 6, 2020
@TylerLubeck TylerLubeck deleted the topics_management branch February 6, 2020 20:34
@jeffwidman
Copy link
Contributor

Sure, although wouldn't rebasing or merging in master here have done the same thing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants