Improve KafkaConnection with more tests #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 17, 2014 16:05
| @@ -55,6 +55,7 @@ def __init__(self, host, port, timeout=DEFAULT_SOCKET_TIMEOUT_SECONDS): | |||
| self.host = host | |||
| self.port = port | |||
| self.timeout = timeout | |||
| self._dirty = None | |||
There was a problem hiding this comment.
any reason this is None instead of False? True|False is used everywhere else.
There was a problem hiding this comment.
_dirty is a description of the state of our socket in _sock. Because we dont have a _sock yet, we also dont really have a _dirty state either. But to be consistent we should probably set also _dirty to None in close() when we set _sock to None
added 15 commits
August 19, 2014 21:27
…ests for __init__ and send
…a return val check in KafkaConnection.send()
… into try block in conn.recv
…cket payloads, then '', then error
dpkp
added a commit
that referenced
this pull request
Aug 22, 2014
Improve KafkaConnection with more tests
wbarnha
pushed a commit
to orange-kao/kafka-python
that referenced
this pull request
Aug 17, 2024
According to [rfc5802](https://datatracker.ietf.org/doc/html/rfc5802), username should escape special characters before sending to the server. > The characters ',' or '=' in usernames are sent as '=2C' and '=3D' respectively. If the server receives a username that contains '=' not followed by either '2C' or '3D', then the server MUST fail the authentication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle connection failures in KafkaConnection.reinit
Set _sock=None in close()
Also check for no _sock when checking for _dirty
Add a few more debugging log messages
Implement the skipped connection tests in test/test_conn.py