Skip to content

Enable continuous integration with travis-ci. #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2013
Merged

Enable continuous integration with travis-ci. #53

merged 1 commit into from
Oct 2, 2013

Conversation

jimjh
Copy link
Contributor

@jimjh jimjh commented Oct 2, 2013

As the number of contributors increase, it becomes more important to make sure that everyone is able to get started quickly on a clean slate, where 'clean' is defined by the unit tests and integration tests. It also avoids "but it runs on my machine!" scenarios. This pull request adds a travis configuration file which instructs travis-ci to run the tests. A badge indicating the status is included in the README. Rails is a great example of a project using travis successfully.

Note that you will need to enable github to notify travis whenever a push is made.

At this point, it appears that py2.6 doesn't work too well with expectFailures, and that some of the integration tests are failing. I would like to have your help with these.

@mumrah
Copy link
Collaborator

mumrah commented Oct 2, 2013

@jimjh CI would be wonderful - I'd never seen TravisCI before (what's with all the butler references?)

What are the limitations as to what you can run in TravisCI. For the integration tests we require a running ZooKeeper and Kafka broker(s). This requires running the sbt targets in kafka-src.

@mumrah
Copy link
Collaborator

mumrah commented Oct 2, 2013

Just looked at the yml file and I see you have the SBT commands in there - very cool. I will definitely check this out.

mumrah added a commit that referenced this pull request Oct 2, 2013
Enable continuous integration with travis-ci.
@mumrah mumrah merged commit b10b73a into dpkp:master Oct 2, 2013
@jimjh jimjh deleted the testing branch October 2, 2013 13:54
@jimjh
Copy link
Contributor Author

jimjh commented Oct 2, 2013

Great! Travis and Github integrates nicely and even runs tests on pull requests. Detailed docs are available here.

Let's work on getting the tests to pass next.

@mumrah
Copy link
Collaborator

mumrah commented Oct 2, 2013

@jimjh yup. @mrtheb is working on updating the tests with the latest 0.8 Kafka version (See #51).

@mrtheb
Copy link
Collaborator

mrtheb commented Oct 2, 2013

@jimjh pretty nice, I was leaning towards that as well. Any idea if Travis-CI finally has support for windows? (I know... I shouldn't do that but that's an unfortunate requirement of mine :-()

Can you help enable it in the 0.8 branch?

@mumrah
Copy link
Collaborator

mumrah commented Oct 2, 2013

@jimjh well since it's Python it should "just work" on Windows, right? ;)

@jimjh
Copy link
Contributor Author

jimjh commented Oct 2, 2013

@mrtheb No, I don't think they support windows yet. But it looks like they are working on it.

@mumrah That was what Java said. Heh.

@jimjh
Copy link
Contributor Author

jimjh commented Oct 2, 2013

I believe travis-ci runs all branches by default. Anw, I don't think I have access to the repository settings on travis since I am not a committer.

@mahendra
Copy link
Collaborator

mahendra commented Oct 4, 2013

@mumrah python multiprocessing seems to have issues with windows :-P
so windows support will be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants