flake8 (pep8 and pyflakes) clean-up #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumrah
added a commit
that referenced
this pull request
Oct 4, 2013
flake8 (pep8 and pyflakes) clean-up
|
Just an FYI to the PEP8 police (@nekto0n, @mrtheb, @mahendra), they did recently extend the max line width to 99 characters. http://hg.python.org/peps/file/fb24c80e9afb/pep-0008.txt#l159 ;) |
|
@mumrah Hooray! :) |
|
@mumrah yep, I saw that a while ago. I am not a big fan of 80chars limit either but I try to stay close for others who might like it. The most important in this request were the import warnings from pyflakes. As a sidenote, I laughed and liked when I saw this on Kafka's coding quide
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the effort started by @nekto0n, I ran flake8 on the whole project to: