Skip to content

reduce memory copies when consuming kafka responses #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 28, 2013
Merged

reduce memory copies when consuming kafka responses #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions kafka/conn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,9 @@ def __str__(self):

def _consume_response(self):
"""
Fully consumer the response iterator
Fully consume the response iterator
"""
data = ""
for chunk in self._consume_response_iter():
data += chunk
return data
return "".join(self._consume_response_iter())

def _consume_response_iter(self):
"""
Expand Down