Changes for aligning code with offset fetch and commit APIs (Kafka 0.8.1) #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdiomar
added a commit
that referenced
this pull request
Jan 16, 2014
Changes for aligning code with offset fetch and commit APIs (Kafka 0.8.1)
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit # 5581649 ::
Kafka API keys have changed for offset fetch and commit requests.
Refer https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/api/RequestKeys.scala#L32
Commit # daabc9f ::
Latest code in the trunk no longer returns client_id in offset fetch and commit response.
Refer https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/api/OffsetFetchResponse.scala
and https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/api/OffsetCommitResponse.scala