-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Created windows installer. Use batch file to run it #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@stephendade Are you saying this is an installer that will bundle DroneKit and MAVProxy? If so, you are officially awesome! |
Yep :) Although MAVProxy will need to be installed separately using it's own installer. |
I've kept MAVProxy and droneAPI separate in order to make the version control easier. |
@stephendade We are not worthy. Thank you! |
@mrpollo @djnugent I've tested this using a test file Stephen provided and also one I built using the instructions (now added as description). It works well! The installer script fetches the build number from setup.py to create the build number. We need to set up the toolchain to build this automatically every time we make a new release. We also need to decide where/how to host this. It would be good if we could have on a server somewhere with a symlink for "latest" version (like mavproxy does here ). Thoughts. Anyway, would be excellent if you could merge this in. Many thanks to you @stephendade |
first of thanks to @stephendade for going the extra mile and providing a great PR with clear instructions and readable code. @stephendade can you please change the wording on any user facing copy from DroneApi to DroneKit?, I think there are at least 2 labels that I can see from reading the code, not sure if when executing more come up. second, @hamishwillee this brings some related tasks into consideration:
I'm merging this PR as soon as @stephendade can help us by fixing the wording to match our Marketing 🏢 @hamishwillee can you create new issues from our list above we can go in depth about them there, and also create a milestone for the next release of DroneKit, we will do a new release as soon as those are in and anything else that we can get in between. Again, outstanding work @stephendade |
@stephendade Great work! However, my experience was not perfect. I get this error when I try to import droneapi: |
@stephendade Does the MAVProxy installer clean/replace Windows MAVProxy init file every time it is installed? (%HOMEPATH%\AppData\Local\MAVProxy\mavinit.scr) ? |
@hamishwillee - yes it does replace the file each time |
@mrpollo - naming fixed! |
@stephendade thanks! |
Created windows installer. Use batch file to run it
@stephendade Thoughts on that protobuf issue above? Protobuf is listed as a droneapi dependency in pip. |
@hamishwillee I'm travelling at the moment, but I should have a chance to look into it sometime this week. |
@stephendade Thanks very much. I was away last week too. |
Installer details
Using Installer script
Preconditions
Build the installation file using \dronekit-python\windows>droneapiWinBuild.bat
The script gets the version number from dronekit's setup.py (It assumes there is a line like
# version = "12344"
)