Skip to content

Working Fix For Pattern Lab Lineages When Using Custom Twig Namespaces #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

sghoweri
Copy link
Collaborator

@sghoweri sghoweri commented Oct 1, 2017

Addresses original issue opened here: EvanLovely/plugin-twig-namespaces#4

Without this workaround when using the Pattern Lab Twig Namespaces plugin using a path / directory other than the one PL would normally assign (ex. one single @mylibrary alias for any pattern to be included by) the original Lineage fix stops working entirely and you get dozens and dozens and dozens of warnings saying you're PL includes / embeds / extends aren't referencing a real pattern.

CC @evanmwillhite @jesconstantine @bradfrost

@sghoweri
Copy link
Collaborator Author

sghoweri commented Oct 1, 2017

  • CC @bmuenzenmeyer since these are the sorts of things we'll need to work through in trying to unify the PHP and Node Pattern Lab cores (perhaps bumping this sort of thing to code handling the Twig Engine / adapter)

@sghoweri
Copy link
Collaborator Author

sghoweri commented Oct 6, 2017

Closing out - new PR opened pattern-lab#127

@sghoweri sghoweri closed this Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants