Skip to content

Bookmarks Feature Refactoring and Bug Fixes #6147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 32 commits into
base: develop
Choose a base branch
from

Conversation

seabornlee
Copy link

Task/Issue URL: #6062

Description

This PR refactors the bookmarks feature to improve code quality and fix several bookmark-related bugs. Key changes include:

  • Refactoring:

    • Extracted BookmarksSearchActivity to separate search functionality
    • Created HiddenIdsManager to eliminate code duplication
  • Bug Fixes:

    • Fixed deleted bookmarks still appearing in search results
    • Fixed deleted bookmarks not being hidden properly
    • Fixed child item count updates
    • Fixed deletion of items in search activity
  • Testing:

    • Added Maestro tests for bookmark functionality
    • Added unit tests for new components

Steps to test this PR

Bookmark Management

  • Create, edit and delete bookmarks
  • Verify deleted bookmarks don't appear in search results
  • Add and rem^Cove favorites
  • Edit bookmark location and folder

Bookmark Search

  • Search for bookmarks
  • Verify folder management works correctly during search
  • Verify deleted items are immediately removed from search results

Folder Management

  • Create, edit and delete folders
  • Verify child item counts update correctly

UI changes

Before After
Can search in only sub folder Can search in root bookmark folder

@seabornlee seabornlee requested a review from malmstein as a code owner May 27, 2025 12:57
@seabornlee
Copy link
Author

seabornlee commented May 29, 2025

@CDRussell @joshliebe @nalcalag Could you please take a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant