Skip to content

remove top-level feature toggle reference from visual design store #6163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

LukasPaczos
Copy link
Contributor

Task/Issue URL: https://app.asana.com/1/137249556945/project/1208671518894266/task/1210397555776032?focus=true

Description

Removes the check of the parent flag - it's unnecessary for controlling the rollout and could lead to some mistakes in the future. Just checking the visualUpdatesFeature child is enough.

Steps to test this PR

  • Clear the cache and launch the app.
  • Verify visual design is disabled.
  • Load https://www.jsonblob.com/api/1377904106999570432 and restart the app.
  • Verify visual design is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants