Implement feature flag enrolment API #6177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aitorvs
force-pushed
the
feature/aitor/ff/enrollment
branch
3 times, most recently
from
bc9137e to
8698ba0
Compare
| @@ -55,13 +55,13 @@ class ReactivateUsersExperimentImpl @Inject constructor( | |||
| ) : ReactivateUsersExperiment { | |||
|
|
|||
| override suspend fun isControl(): Boolean = | |||
| reactivateUsersToggles.reactivateUsersExperimentMay25().isEnabled(CONTROL) | |||
| reactivateUsersToggles.reactivateUsersExperimentMay25().isEnrolledAndEnabled(CONTROL) | |||
There was a problem hiding this comment.
This experiment is missing enrolling users too, I think we can do it in the evaluate method of RealDaxPrompts right after checking the user is eligible (line 55)? cc @anikiki to double check.
There was a problem hiding this comment.
@marcosholgado @anikiki can you check the latest commit to see if that's what we want?
There was a problem hiding this comment.
I checked and it's what we want 👍
mikescamell
reviewed
Jun 4, 2025
...rc/main/java/com/duckduckgo/app/browser/senseofprotection/SenseOfProtectionExperimentImpl.kt
Show resolved
Hide resolved
mikescamell
reviewed
Jun 4, 2025
...rc/main/java/com/duckduckgo/app/browser/senseofprotection/SenseOfProtectionExperimentImpl.kt
Show resolved
Hide resolved
|
@aitorvs I pushed a commit that fixes the |
nalcalag
reviewed
Jun 5, 2025
...ions-impl/src/main/java/com/duckduckgo/subscriptions/impl/ui/SubscriptionWebViewViewModel.kt
Outdated
Show resolved
Hide resolved
aitorvs
force-pushed
the
feature/aitor/ff/enrollment
branch
from
5d7fb7b to
5cd6e2b
Compare
aitorvs
force-pushed
the
feature/aitor/ff/enrollment
branch
from
3df3c69 to
d6eb4b7
Compare
aitorvs
force-pushed
the
feature/aitor/ff/enrollment
branch
from
2839a64 to
e0cfb55
Compare
…esignShieldThenUseNonExperimentAssets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1198194956794324/task/1210415399293026?focus=true
Description
Implement the enrolment API as defined in API Proposal: feature flag enrolment API
Steps to test this PR
We tested the following experiments
Thanks @marcosholgado, @mikescamell , @anikiki , @LukasPaczos