Skip to content

Duck.ai: Show Duck.ai button in browser #6189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Duck.ai: Show Duck.ai button in browser #6189

wants to merge 1 commit into from

Conversation

0nko
Copy link
Member

@0nko 0nko commented Jun 6, 2025 •
edited by anikiki
Loading

Task/Issue URL: https://app.asana.com/1/137249556945/project/1207418217763355/task/1210461726063206?focus=true

Description

This PR updates the Duck.ai button display logic to always show it in the browser mode.

Steps to test this PR

  • Start the app
  • Verify the Duck.ai button is displayed in the omnibar in the browser mode (loaded website)
  • Select the URL
  • Verify the Duck.ai button is displayed
  • Open a NTP
  • Verify the Duck.ai button is displayed
  • Go to Settings -> Duck.ai
  • Disable the Address bar toggle
  • Go back to the the browser
  • Verify the Duck.ai button is gone

UI changes

Before After
image image

@anikiki anikiki self-assigned this Jun 6, 2025
anikiki
anikiki approved these changes Jun 6, 2025
View reviewed changes
Copy link
Contributor

@anikiki anikiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anikiki anikiki anikiki approved these changes

Assignees

@anikiki anikiki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0nko @anikiki