-
Notifications
You must be signed in to change notification settings - Fork 989
Update web to search interstitial transition #6204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2af22bf
to
8ee1bb4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the transition behavior from the browser tab to the search interstitial, ensuring that the entered query is passed correctly between activities and that shared element transitions are used for a smoother UI experience.
- Added a transition name ("omnibar_transition") to the omnibar layouts.
- Modified the SearchInterstitialActivity to retrieve and return query data via activity results.
- Updated the BrowserTabFragment to launch the interstitial with a shared element transition.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
duckchat-impl/src/main/res/layout/view_duck_chat_omnibar.xml | Added transitionName attribute for shared element transitions. |
duckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/ui/SearchInterstitialActivity.kt | Updated activity parameters and result handling to support interstitial navigation with shared transitions. |
duckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/ui/DuckChatOmnibarLayout.kt | Removed text clearing from duckChatInput to preserve input state. |
app/src/main/res/layout/view_fade_omnibar.xml | Added transitionName attribute for shared element transitions. |
app/src/main/java/com/duckduckgo/app/browser/omnibar/experiments/FadeOmnibarLayout.kt | Changed access modifier for omniBarClickCatcher, removing the click listener to delegate handling. |
app/src/main/java/com/duckduckgo/app/browser/omnibar/Omnibar.kt | Exposed omnibar container and click catcher for transition handling. |
app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt | Added activity result launcher and click catcher configuration to support the new interstitial transition with shared elements. |
936a2ac
to
f363b07
Compare
f363b07
to
6351872
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Left a nit, maybe we want to add a TODO in kdoc to signal we may want to come back to the nit comment.
Works as expected
Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1210498773096186?focus=true
Description
Steps to test this PR