Skip to content

iOS Malicious Site Protection - Ship Review feedback #1433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

mgurgel
Copy link
Contributor

@mgurgel mgurgel commented Jan 28, 2025

Asana Task/Github Issue: https://app.asana.com/0/0/1209233393259133/f

Description

  • Introduces data-line-break attribute to allow inserting line breaks before inline elements
  • Applies data-line-break to the Learn More link on the iOS Phishing and Malware warnings

Testing Steps

Before
image

After
image

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit bffa14e
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/679a0a41fcf2df0008d16b84
😎 Deploy Preview https://deploy-preview-1433--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Jan 28, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Jan 28, 2025

[Beta] Generated file diff

Time updated: Wed, 29 Jan 2025 11:02:48 GMT

Integration
    - integration/pages/special-error/dist/index.css
  • integration/pages/special-error/dist/index.js

File has changed

Apple
    - dist/pages/special-error/dist/index.css
  • dist/pages/special-error/dist/index.js
  • dist/pages/special-error/index.html

File has changed

@mgurgel mgurgel marked this pull request as ready for review January 28, 2025 10:58
@mgurgel mgurgel requested review from shakyShane and a team as code owners January 28, 2025 10:58
@mgurgel mgurgel force-pushed the mgurgel/malware-ios-feedback branch from b4d0b09 to bffa14e Compare January 29, 2025 11:00
@mgurgel mgurgel merged commit 0f9d508 into main Jan 29, 2025
12 checks passed
@mgurgel mgurgel deleted the mgurgel/malware-ios-feedback branch January 29, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants