Skip to content

history: working on data model + NTP hotfix #1468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Feb 5, 2025

Asana Task/Github Issue:

Description

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane
Copy link
Contributor Author

shakyShane commented Feb 5, 2025

Copy link

netlify bot commented Feb 5, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit dea542c
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67a6205c5d7ed80008f7f8b5
😎 Deploy Preview https://deploy-preview-1468--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Feb 5, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Feb 5, 2025

[Beta] Generated file diff

Time updated: Fri, 07 Feb 2025 15:04:21 GMT

Integration
    - integration/pages/history/dist/index.css
  • integration/pages/history/dist/index.js
  • integration/pages/history/locales/en/history.json
  • integration/pages/new-tab/dist/index.css
  • integration/pages/new-tab/dist/index.js

File has changed

Windows
    - windows/pages/history/dist/index.css
  • windows/pages/history/dist/index.js
  • windows/pages/history/locales/en/history.json
  • windows/pages/new-tab/dist/index.css

File has changed

Apple
    - dist/pages/history/dist/index.css
  • dist/pages/history/dist/index.js
  • dist/pages/history/locales/en/history.json
  • dist/pages/new-tab/dist/index.css

File has changed

New Files
    - integration/pages/history/icons/all.svg
  • integration/pages/history/icons/closed.svg
  • integration/pages/history/icons/day.svg
  • integration/pages/history/icons/older.svg
  • integration/pages/history/icons/today.svg
  • integration/pages/history/icons/yesterday.svg
  • windows/pages/history/icons/all.svg
  • windows/pages/history/icons/closed.svg
  • windows/pages/history/icons/day.svg
  • windows/pages/history/icons/older.svg
  • windows/pages/history/icons/today.svg
  • windows/pages/history/icons/yesterday.svg
  • dist/pages/history/icons/all.svg
  • dist/pages/history/icons/closed.svg
  • dist/pages/history/icons/day.svg
  • dist/pages/history/icons/older.svg
  • dist/pages/history/icons/today.svg
  • dist/pages/history/icons/yesterday.svg

❌ File only exists in new changeset

@shakyShane shakyShane force-pushed the 01-21-history_working_on_data_model branch 3 times, most recently from d19391f to eea41dd Compare February 7, 2025 09:57
@shakyShane shakyShane changed the base branch from main to 02-07-history_create_specialized_list_component_hooks February 7, 2025 09:57
Base automatically changed from 02-07-history_create_specialized_list_component_hooks to main February 7, 2025 14:57
@shakyShane shakyShane force-pushed the 01-21-history_working_on_data_model branch from 61ad9cb to dea542c Compare February 7, 2025 15:01
@shakyShane shakyShane marked this pull request as ready for review February 7, 2025 15:03
@shakyShane shakyShane requested review from mgurgel and a team as code owners February 7, 2025 15:03
@shakyShane shakyShane changed the title history: working on data model history: working on data model + NTP hotfix Feb 7, 2025
Copy link

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😎 nicely spotted, @shakyShane!

@shakyShane shakyShane merged commit aacf81d into main Feb 7, 2025
20 checks passed
@shakyShane shakyShane deleted the 01-21-history_working_on_data_model branch February 7, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants