Skip to content

history: favicon support #1490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 15, 2025

Conversation

shakyShane
Copy link
Contributor

Asana Task/Github Issue:

Description

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane shakyShane marked this pull request as ready for review February 15, 2025 21:36
@shakyShane shakyShane requested review from mgurgel and a team as code owners February 15, 2025 21:36
@shakyShane shakyShane mentioned this pull request Feb 15, 2025
10 tasks
@shakyShane
Copy link
Contributor Author

shakyShane commented Feb 15, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@shakyShane shakyShane mentioned this pull request Feb 15, 2025
10 tasks
Copy link

github-actions bot commented Feb 15, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Feb 15, 2025

[Beta] Generated file diff

Time updated: Sat, 15 Feb 2025 21:59:34 GMT

Integration
    - integration/pages/history/dist/index.css
  • integration/pages/history/dist/index.js
  • integration/pages/history/icons/clock.svg
  • integration/pages/history/locales/en/history.json
  • integration/pages/new-tab/dist/index.css
  • integration/pages/new-tab/dist/index.js

File has changed

Windows
    - windows/pages/history/dist/index.css
  • windows/pages/history/dist/index.js
  • windows/pages/history/icons/clock.svg
  • windows/pages/history/locales/en/history.json
  • windows/pages/new-tab/dist/index.css
  • windows/pages/new-tab/dist/index.js

File has changed

Apple
    - dist/pages/history/dist/index.css
  • dist/pages/history/dist/index.js
  • dist/pages/history/icons/clock.svg
  • dist/pages/history/locales/en/history.json
  • dist/pages/new-tab/dist/index.css
  • dist/pages/new-tab/dist/index.js

File has changed

New Files
    - integration/pages/history/company-icons/other-dark.svg
  • integration/pages/history/company-icons/other.svg
  • integration/pages/history/icons/backdrop.svg
  • windows/pages/history/company-icons/other-dark.svg
  • windows/pages/history/company-icons/other.svg
  • windows/pages/history/icons/backdrop.svg
  • dist/pages/history/company-icons/other-dark.svg
  • dist/pages/history/company-icons/other.svg
  • dist/pages/history/icons/backdrop.svg

❌ File only exists in new changeset

@shakyShane shakyShane merged commit 8b15d32 into shane/history-multi-select Feb 15, 2025
6 of 7 checks passed
@shakyShane shakyShane deleted the 02-15-history_favicon_support branch February 15, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant