Skip to content

history: use double-click for opening links #1534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Mar 3, 2025

Asana Task/Github Issue: https://app.asana.com/0/0/1209547462194588/f

Description

  • change the behaviour of a row - now you have to double-click (or right-click) to open as a link

Testing Steps

  • For these, check the console.
    • double-click a row
    • double-click a row with shift
    • double-click a row CMD/CTRL

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane
Copy link
Contributor Author

shakyShane commented Mar 3, 2025

Copy link

github-actions bot commented Mar 3, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Mar 3, 2025

[Beta] Generated file diff

Time updated: Mon, 03 Mar 2025 15:29:10 GMT

Integration
    - integration/pages/history/dist/index.css
  • integration/pages/history/dist/index.js

File has changed

Windows
    - windows/pages/history/dist/index.css
  • windows/pages/history/dist/index.js

File has changed

Apple
    - dist/pages/history/dist/index.css
  • dist/pages/history/dist/index.js

File has changed

@shakyShane shakyShane marked this pull request as ready for review March 3, 2025 14:20
@shakyShane shakyShane requested review from mgurgel and a team as code owners March 3, 2025 14:20
Base automatically changed from 03-03-history_reset_to_default_query_following_delete to main March 3, 2025 15:27
@shakyShane shakyShane force-pushed the 03-03-history_use_double-click_for_opening_links branch from 6e6059d to 0cf2f12 Compare March 3, 2025 15:28
Copy link

netlify bot commented Mar 3, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 0cf2f12
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67c5ca86648dee00086c6079
😎 Deploy Preview https://deploy-preview-1534--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@mgurgel mgurgel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and reviewed 👍

@shakyShane shakyShane merged commit 809166f into main Mar 3, 2025
13 checks passed
@shakyShane shakyShane deleted the 03-03-history_use_double-click_for_opening_links branch March 3, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants