Skip to content

Enables Duck Player custom error on all platforms #1535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 19, 2025

Conversation

mgurgel
Copy link
Contributor

@mgurgel mgurgel commented Mar 3, 2025

Asana Task/Github Issue: https://app.asana.com/0/0/1209459625347015
https://app.asana.com/0/0/1209459625347014

Description

  • Implements the custom error screen for Duck Player on Android and Windows
  • Adds legacy support for Apple/Windows custom error settings schema and new Android-compatible schema

Testing Steps

Test builds

Android

  1. Override privacy config to https://www.jsonblob.com/api/jsonBlob/1344674224849215488
  2. Follow the steps here: https://app.asana.com/0/1142021229838617/1209392401656236

Windows

  1. Override privacy config to https://www.jsonblob.com/api/jsonBlob/1345007201051402240
  2. Follow the steps here: https://app.asana.com/0/1142021229838617/1209392401656236

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@mgurgel mgurgel requested review from shakyShane and a team as code owners March 3, 2025 17:08
Copy link

netlify bot commented Mar 3, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit d8738fe
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67daba074bbc830008a93084
😎 Deploy Preview https://deploy-preview-1535--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Mar 3, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Mar 3, 2025

[Beta] Generated file diff

Time updated: Wed, 19 Mar 2025 12:36:25 GMT

Android
    - android/pages/duckplayer/dist/index.js

File has changed

Integration
    - integration/pages/duckplayer/dist/index.js

File has changed

Windows
    - windows/pages/duckplayer/dist/index.js

File has changed

Apple
    - dist/pages/duckplayer/dist/index.js
  • dist/pages/duckplayer/index.html

File has changed

@mgurgel mgurgel changed the title Enabled Duck Player custom error on all platforms Enables Duck Player custom error on all platforms Mar 3, 2025
shakyShane
shakyShane previously approved these changes Mar 3, 2025
@mgurgel mgurgel force-pushed the mgurgel/duckplayer-custom-error-windows-android branch 2 times, most recently from b509d44 to 47b76d3 Compare March 13, 2025 13:25
@mgurgel mgurgel self-assigned this Mar 13, 2025
@mgurgel mgurgel force-pushed the mgurgel/duckplayer-custom-error-windows-android branch from 47b76d3 to e4a8f95 Compare March 18, 2025 15:54
@mgurgel mgurgel force-pushed the mgurgel/duckplayer-custom-error-windows-android branch from e4a8f95 to d8738fe Compare March 19, 2025 12:35
@mgurgel mgurgel merged commit bba8ed2 into main Mar 19, 2025
12 checks passed
@mgurgel mgurgel deleted the mgurgel/duckplayer-custom-error-windows-android branch March 19, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants