history: scrollbars #1536
Merged
history: scrollbars #1536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Tue, 04 Mar 2025 09:00:35 GMT IntegrationFile has changed WindowsFile has changed AppleFile has changed |
shakyShane
commented
Mar 4, 2025
Comment on lines
74
to
107
| /** | ||
| * macOS specific styling to handle dark mode - without this full | ||
| * override you cannot change the track color :( | ||
| */ | ||
| [data-platform="macos"] { | ||
| .customScroller { | ||
| --webkit-thumb-color: rgba(136, 136, 136, 0.8); | ||
|
|
||
| &::-webkit-scrollbar { | ||
| width: var(--scrollbar-width); | ||
| } | ||
|
|
||
| &::-webkit-scrollbar-track { | ||
| background-color: var(--history-background-color) | ||
| } | ||
|
|
||
| &::-webkit-scrollbar-thumb { | ||
| background-color: var(--webkit-thumb-color); | ||
| border-radius: calc(var(--scrollbar-width) / 2); | ||
|
|
||
| /** faking some padding on the thumb */ | ||
| border: 4px solid var(--history-background-color); | ||
| } | ||
|
|
||
| &::-webkit-scrollbar-button { | ||
| display: block; | ||
| background-color: var(--history-background-color); | ||
|
|
||
| /** a small vertical gap to prevent it touching boundaries */ | ||
| height: 2px; | ||
| } | ||
| } | ||
| } No newline at end of file | ||
| } |
There was a problem hiding this comment.
Ideally, we wouldn't need this. But for now it gets the project over the line. The window example above is preferred.
shakyShane
commented
Mar 4, 2025
| .customScroller { | ||
| overflow-y: scroll; | ||
| scrollbar-gutter: stable; | ||
| padding-right: calc(var(--main-padding-right) - var(--scrollbar-width)); |
There was a problem hiding this comment.
This helps the alignment of selected rows, ensuring they perfectly match the search bar in the header
dbajpeyi
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue: https://app.asana.com/0/0/1209565728475049/f
Description
Testing Steps
macOS
Windows
Checklist
Please tick all that apply: