Skip to content

ntp: fix layout of RMF widget on older macOS #1548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Mar 6, 2025

Asana Task/Github Issue: https://app.asana.com/0/1201141132935289/1209495940971615

Description

  • on older macos versions, the behaviour of flexbox was causing the layout issue in the screenshots.

Testing Steps

Production:
image

This PR:
image

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

netlify bot commented Mar 6, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 3d5f52f
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67c9674f90a50c000859f510
😎 Deploy Preview https://deploy-preview-1548--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Mar 6, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@shakyShane shakyShane marked this pull request as ready for review March 6, 2025 09:14
Copy link

github-actions bot commented Mar 6, 2025

[Beta] Generated file diff

Time updated: Thu, 06 Mar 2025 09:15:54 GMT

Integration
    - integration/pages/new-tab/dist/index.css
  • integration/pages/new-tab/dist/index.js

File has changed

Windows
    - windows/pages/new-tab/dist/index.css

File has changed

Apple
    - dist/pages/new-tab/dist/index.css

File has changed

@shakyShane shakyShane requested review from mgurgel and a team as code owners March 6, 2025 09:14
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before, the content was allowed to grow, but I flipped the model and allowed it to shrink instead, and now it works everywhere :)

Comment on lines +174 to +175
const prod = new URL('/build/pages/new-tab', 'https://content-scope-scripts.netlify.app');
prod.search = url.search;
Copy link
Contributor

@dbajpeyi dbajpeyi Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question (non-blocking): Could be nice to move the hardcoded base URL somewhere common?

Copy link
Contributor

@dbajpeyi dbajpeyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One curiousity question, but LGTM!

@shakyShane shakyShane merged commit 32f8e01 into main Mar 6, 2025
23 checks passed
@shakyShane shakyShane deleted the 03-06-ntp_fix_layout_of_rmf_widget_on_older_macos branch March 6, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants