Skip to content

add favicon feature #1561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 21, 2025
Merged

add favicon feature #1561

merged 14 commits into from
Mar 21, 2025

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Mar 14, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1201141132935289/task/1209667199269997?focus=true

Description

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Mar 14, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@shakyShane shakyShane marked this pull request as ready for review March 14, 2025 10:29
@shakyShane shakyShane requested a review from a team as a code owner March 14, 2025 10:29
Copy link

netlify bot commented Mar 14, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit eb50be8
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67dda2d0b7b81400071a3e4c
😎 Deploy Preview https://deploy-preview-1561--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shakyShane shakyShane changed the title add favicon feature [wip] add favicon feature Mar 14, 2025
Copy link

github-actions bot commented Mar 14, 2025

[Beta] Generated file diff

Time updated: Fri, 21 Mar 2025 17:33:43 GMT

Android
    - android/autofillPasswordImport.js
  • android/brokerProtection.js
  • android/contentScope.js

File has changed

Chrome-mv3
    - chrome-mv3/inject.js

File has changed

Firefox
    - firefox/inject.js

File has changed

Integration
    - integration/contentScope.js

File has changed

Windows
    - windows/contentScope.js

File has changed

Apple
    - dist/contentScope.js
  • dist/contentScopeIsolated.js

File has changed

@shakyShane shakyShane force-pushed the shane/favicon branch 2 times, most recently from cabb5b3 to 768b823 Compare March 20, 2025 11:20
@shakyShane shakyShane changed the title [wip] add favicon feature add favicon feature Mar 20, 2025
@shakyShane
Copy link
Contributor Author

@muodov I think I've resolved your feedback in 483c472

muodov
muodov previously approved these changes Mar 21, 2025
Copy link
Member

@muodov muodov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, just a small nit about loop breaking.

muodov
muodov previously approved these changes Mar 21, 2025
@shakyShane
Copy link
Contributor Author

@jonathanKingston - do you know what's up with the review status here? (eg: I can't merge after @muodov 's approval)

@shakyShane shakyShane merged commit 1548938 into main Mar 21, 2025
13 of 14 checks passed
@shakyShane shakyShane deleted the shane/favicon branch March 21, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants