Skip to content

allow non-protection features to survive protections toggle #1564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 20, 2025

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Mar 14, 2025

Asana Task/Github Issue: https://app.asana.com/0/1201141132935289/1209713939349679/f

Description

  • apple, android, windows: only call 'load' on features if they are enabled in config
  • apple, android, windows: don't return early if protections were toggled
  • extension: NO CHANGE: load will be called for every feature in the bundle as before

apple, android, windows:

Untitled (5)

extension:

image

Testing Steps

  • updated tests to show no impact.

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

netlify bot commented Mar 14, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 1fb3df5
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67dbf82480693e0008a2be71
😎 Deploy Preview https://deploy-preview-1564--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Mar 14, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Mar 14, 2025

[Beta] Generated file diff

Time updated: Thu, 20 Mar 2025 11:13:18 GMT

Android
    - android/autofillPasswordImport.js
  • android/brokerProtection.js
  • android/contentScope.js

File has changed

Chrome-mv3
    - chrome-mv3/inject.js

File has changed

Firefox
    - firefox/inject.js

File has changed

Integration
    - integration/contentScope.js
  • integration/pages/new-tab/dist/index.js

File has changed

Windows
    - windows/contentScope.js
  • windows/pages/new-tab/dist/index.js

File has changed

Apple
    - dist/contentScope.js
  • dist/contentScopeIsolated.js
  • dist/pages/new-tab/dist/index.js

File has changed

@shakyShane shakyShane force-pushed the 03-14-poc_allow_features_to_survive_toggle branch 4 times, most recently from 281cca3 to 7c84a11 Compare March 19, 2025 20:00
@shakyShane shakyShane marked this pull request as ready for review March 19, 2025 20:00
@shakyShane shakyShane requested review from a team as code owners March 19, 2025 20:00
@shakyShane shakyShane force-pushed the 03-14-poc_allow_features_to_survive_toggle branch from 7c84a11 to 52758f1 Compare March 19, 2025 20:01
Copy link
Contributor

@jonathanKingston jonathanKingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test but looks as expected, thanks for doing this!

@shakyShane shakyShane changed the title poc: allow features to survive toggle allow features to survive toggle Mar 20, 2025
@shakyShane shakyShane changed the title allow features to survive toggle allow features to survive protections toggle Mar 20, 2025
@shakyShane shakyShane changed the title allow features to survive protections toggle allow non-protection features to survive protections toggle Mar 20, 2025
@shakyShane shakyShane merged commit 27b7e0f into main Mar 20, 2025
15 checks passed
@shakyShane shakyShane deleted the 03-14-poc_allow_features_to_survive_toggle branch March 20, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants