Skip to content

Fix a zoom issue in emulated desktop mode on Android #1573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 17, 2025

Conversation

muodov
Copy link
Member

@muodov muodov commented Mar 17, 2025

Asana Task/Github Issue:
https://app.asana.com/1/137249556945/project/1206777341262243/task/1207691440660873?focus=true

Description

Fix an issue with emulated desktop mode on Adnroid. This affects instagram.com.

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@muodov muodov requested a review from a team as a code owner March 17, 2025 12:50
Copy link

netlify bot commented Mar 17, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 774ae5d
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67d85b7271b0b50007f21f70
😎 Deploy Preview https://deploy-preview-1573--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Mar 17, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Mar 17, 2025

[Beta] Generated file diff

Time updated: Mon, 17 Mar 2025 17:28:03 GMT

Android
    - android/contentScope.js

File has changed

Integration
    - integration/contentScope.js

File has changed

Apple
    - dist/contentScope.js

File has changed

@muodov muodov requested a review from jonathanKingston March 17, 2025 13:02
@muodov muodov force-pushed the max/viewport-fix branch from 0d9a200 to c6b7bf4 Compare March 17, 2025 13:04
@muodov muodov requested a review from jonathanKingston March 17, 2025 13:21
@muodov muodov force-pushed the max/viewport-fix branch from 73c376b to 4f11840 Compare March 17, 2025 15:29
@jonathanKingston jonathanKingston merged commit cd85139 into main Mar 17, 2025
12 checks passed
@jonathanKingston jonathanKingston deleted the max/viewport-fix branch March 17, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants