Skip to content

Pass captcha container element to getSolveCallback #1576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2025
Merged

Pass captcha container element to getSolveCallback #1576

merged 1 commit into from
Mar 18, 2025

Conversation

brianhall
Copy link
Contributor

Asana Task/Github Issue:

Description

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 18, 2025 •
edited
Loading

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 18, 2025 •
edited
Loading

[Beta] Generated file diff

Time updated: Tue, 18 Mar 2025 15:38:35 GMT

Android 
    - android/brokerProtection.js

File has changed

Integration 
    - integration/contentScope.js

File has changed

Windows 
    - windows/contentScope.js

File has changed

Apple 
    - dist/contentScopeIsolated.js

File has changed

@brianhall brianhall mentioned this pull request Mar 18, 2025
Merged
13 tasks
@brianhall brianhall marked this pull request as ready for review March 18, 2025 15:37
@brianhall brianhall requested review from shakyShane and a team as code owners March 18, 2025 15:37
@madblex madblex merged commit 8669f53 into madblex/pir-captcha-providers Mar 18, 2025
13 checks passed
@madblex madblex deleted the bhall/add-captcha-container-to-get-solve-callback branch March 18, 2025 16:59
madblex pushed a commit that referenced this pull request Mar 19, 2025
@brianhall @madblex
Pass captcha container element to getSolveCallback (#1576)
5a62b86
madblex pushed a commit that referenced this pull request Mar 19, 2025
@brianhall @madblex
Pass captcha container element to getSolveCallback (#1576)
9a4d195
madblex added a commit that referenced this pull request Mar 19, 2025
@madblex @brianhall
feat(pir): captcha providers (#1550)
4975042 
* feat(pir): captcha providers

* fix(captcha providers): remove barrel files and fix exports

* feat: address PR feedback:
- replace arrow fn with regular functions
- update provider registry
- align getSupportingCodeToInject return types

* feat: ensure backwards compatibility

* feat(pir): add error object control flow (#1558)

* feat: address PR feedback #2:
- wire up the remote config setting
- replace querying by root with querying by captcha container
- remove hcaptcha and cloudflare providers

* Pass captcha container element to getSolveCallback (#1576)

* feat(pir): captcha providers tests (#1560)

* feat(pir): captcha providers tests

* feat: address PR comments

* feat: amend tests

* fix: add new tests and unroll for loops

* Minor tweaks to wording and removal of hCaptcha mocks

* fix: lint

---------

Co-authored-by: Brian Hall <[email protected]>

* fix: lint errors

---------

Co-authored-by: Brian Hall <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shakyShane shakyShane Awaiting requested review from shakyShane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianhall @madblex