Skip to content

refactor: noUnusedParameters in tsconfig #1579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Conversation

dbajpeyi
Copy link
Contributor

@dbajpeyi dbajpeyi commented Mar 19, 2025

Asana Task/Github Issue:

Description

  • Add noUnusedParameters in tsconfig,
  • Add injected/playwright-report to ignore patterns in eslint and tsconfig
  • Update usage of unused params. Where types can be inferred, changed to _, other places with _<name>, and where it made sense remove it

In some places I don't have enough context, so I've added @ts-expect-error with a comment and we can even remove these later.

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Copy link

netlify bot commented Mar 19, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit e95b27b
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67dab51768334b0008523c85
😎 Deploy Preview https://deploy-preview-1579--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Mar 19, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Mar 19, 2025

[Beta] Generated file diff

Time updated: Wed, 19 Mar 2025 12:14:54 GMT

Android
    - android/autofillPasswordImport.js
  • android/brokerProtection.js
  • android/contentScope.js
  • android/pages/duckplayer/dist/index.js

File has changed

Chrome-mv3
    - chrome-mv3/inject.js

File has changed

Firefox
    - firefox/inject.js

File has changed

Integration
    - integration/contentScope.js
  • integration/pages/duckplayer/dist/index.js
  • integration/pages/example/dist/index.js
  • integration/pages/history/dist/index.js
  • integration/pages/new-tab/dist/index.js
  • integration/pages/release-notes/dist/index.js
  • integration/pages/special-error/dist/index.js

File has changed

Windows
    - windows/contentScope.js
  • windows/pages/duckplayer/dist/index.js
  • windows/pages/history/dist/index.js
  • windows/pages/new-tab/dist/index.js
  • windows/pages/special-error/dist/index.js
  • windows/pages/special-error/index.html

File has changed

Apple
    - dist/contentScope.js
  • dist/contentScopeIsolated.js
  • dist/pages/duckplayer/dist/index.js
  • dist/pages/duckplayer/index.html
  • dist/pages/history/dist/index.js
  • dist/pages/new-tab/dist/index.js
  • dist/pages/release-notes/dist/index.js
  • dist/pages/special-error/dist/index.js
  • dist/pages/special-error/index.html

File has changed

@dbajpeyi dbajpeyi changed the title refactor: camelcase function to use unused parameter in utils.js refactor: ignore unused parameter in utils.js Mar 19, 2025
@dbajpeyi dbajpeyi marked this pull request as ready for review March 19, 2025 08:53
@dbajpeyi dbajpeyi requested review from a team, shakyShane, mgurgel and brianhall as code owners March 19, 2025 08:53
@dbajpeyi dbajpeyi changed the title refactor: ignore unused parameter in utils.js refactor: noUnusedParameters in tsconfig Mar 19, 2025
@shakyShane shakyShane force-pushed the dbajpeyi/chore/unused-var branch from 37024a7 to e95b27b Compare March 19, 2025 12:14
@dbajpeyi dbajpeyi merged commit dc1fde3 into main Mar 19, 2025
13 checks passed
@dbajpeyi dbajpeyi deleted the dbajpeyi/chore/unused-var branch March 19, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants