Skip to content

add snapshot checking in CI #1587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 27, 2025
Merged

add snapshot checking in CI #1587

merged 3 commits into from
Mar 27, 2025

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Mar 27, 2025

Asana Task/Github Issue: https://app.asana.com/0/1201614831475344/1209809168154226/f

Description

This adds 2 new workflows

  • First one will run on PRs/main to verify the snapshots
  • The second one can be manually-triggered (github action) which you can use to update screenshots
    • we learned this is needed to prevent people becoming blocked (for example, if locally generated screenshots don't match)

Note

This PR DOES NOT check the screenshots yet - instead it needs to be merged such that I can verify the workflow dispatch on a following PR (because github doesn't let you test workflows that are not in main)

New Tab Windows (7)

Testing Steps

  • For now, none, providing CI is passing.

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane shakyShane marked this pull request as ready for review March 27, 2025 08:30
@shakyShane shakyShane requested review from mgurgel and a team as code owners March 27, 2025 08:30
@shakyShane
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

netlify bot commented Mar 27, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 993ce64
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67e5150639bdd100081ef493
😎 Deploy Preview https://deploy-preview-1587--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Mar 27, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Mar 27, 2025

[Beta] Generated file diff

Time updated: Thu, 27 Mar 2025 09:06:55 GMT

@mgurgel
Copy link
Contributor

mgurgel commented Mar 27, 2025

Nice diagram :)

@shakyShane shakyShane merged commit 1b0271c into main Mar 27, 2025
20 checks passed
@shakyShane shakyShane deleted the shane/snapshots branch March 27, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants